[oadp-1.6] Migrate Claude e2e failure analysis to claude-ai-helpers step-registry - #2409
Conversation
Backport of openshift#2408 to oadp-1.6. Remove the in-repo Claude CLI/Vertex AI wiring from build/ci-Dockerfile and the Makefile's test-e2e target. The gcp-claude-code-* credential files this relied on were never added to the oadp-credentials vault collection, so it always no-op'd in CI. Failure analysis now runs as an openshift/release step-registry post-step (oadp-analyze-e2e-failure) using the shared claude-ai-helpers image and sa-claude-openshift-ci credential, following the pattern used by medik8s and hypershift. tests/e2e/scripts/analyze_failures.sh is kept for local/manual use only. CLAUDE.md and the design doc are updated to describe the new architecture. oadp-1.4 and oadp-1.5 do not carry this hook (confirmed via grep), so no equivalent change is needed there. Fixes openshift#2407 Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Replace the design doc's content with a fresh description of the current architecture instead of framing it as a superseded/historical document. Drop the "now-superseded" reference from CLAUDE.md. Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
openshift-ci
Bot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, kaovilai, shubham-pampattiwar The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
this pr doesnt touch kubevirt |
|
/override "ci/prow/5.0-e2e-test-kubevirt-aws" |
|
@kaovilai: Overrode contexts on behalf of kaovilai: ci/prow/4.22-e2e-test-kubevirt-aws, ci/prow/5.0-e2e-test-kubevirt-aws DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Summary
Backport of #2408 to
oadp-1.6. Same diff/rationale — removes the in-repo Claude CLI/Vertex AI wiring in favor of the sharedclaude-ai-helpersstep-registry pattern (companionopenshift/releasePR: openshift/release#83957, wiresoadp-analyze-e2e-failureinto bothoadp-1.6andoadp-devci-operator configs).build/ci-Dockerfile: drop Claude CLI install (removesopenshift/veleroclone step too, unlike theoadp-devcopy which wasoadp-dev-branch-based anyway).Makefile'stest-e2etarget: drop thegcp-claude-code-*credential wiring and theanalyze_failures.shinvocation.tests/e2e/scripts/analyze_failures.sh: kept, repurposed for local/manual use only.CLAUDE.md/docs/design/claude-prow-failure-analysis_design.md: updated/marked superseded, same asoadp-dev.oadp-1.4andoadp-1.5were checked and do not carry this hook, so no equivalent PR is needed for those branches.Fixes #2407
Note
Responses generated with Claude